From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
Date: | 2020-01-04 20:46:30 |
Message-ID: | CAH2-Wz=4U_qKeLjN2FnLmSON8B5DgpMNXRdR4mLzgZjdpaMfUg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Sat, Jan 4, 2020 at 11:50 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> So we're going to have to make some decisions about what range of
> libedit builds we want to cater for in the tab-completion tests.
> Given that the plan is to considerably increase the coverage of
> those tests, I'm hesitant to promise that we'll keep passing with
> anything that isn't explicitly tested in the buildfarm, or by active
> developers such as yourself. Maybe that's fine given that end users
> probably don't run the TAP tests.
This sounds similar to "EXTRA_TESTS=collate.linux.utf8". I think that
it's fine to go that way, provided it isn't hard to work around.
FWIW, I find it very surprising that it was possible for the test to
fail on my workstation/server, without it failing on any buildfarm
animals.
--
Peter Geoghegan
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-01-04 20:48:45 | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
Previous Message | Andrew Dunstan | 2020-01-04 20:31:40 | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-01-04 20:48:45 | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
Previous Message | Andrew Dunstan | 2020-01-04 20:31:40 | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |