| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Kamigishi Rei <iijima(dot)yun(at)koumakan(dot)jp>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: BUG #17245: Index corruption involving deduplicated entries |
| Date: | 2021-11-03 02:03:05 |
| Message-ID: | CAH2-Wz=0rbqXFu_hVViv4pF31Q3_6xd1raE0-U8seJLj=hL4gA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Sun, Oct 31, 2021 at 5:19 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> On Sat, Oct 30, 2021 at 3:18 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > Hm. I wonder if it's not actually good to do something like it in 14, given
> > that we know of a path to have corrupted indexes out there.
>
> My concern is that people might not be too happy about errors that
> occur due to corruption in tuples that are only vaguely related to
> their own incoming inserted tuple.
Attached patch adds ERRORs in the event of detecting
index-tuple-TID-points-to-LP_UNUSED conditions, as well as other
similar conditions -- not just assertions, as before.
I do think that this would be a good idea on HEAD. Still have
reservations about doing that for 14, but you're welcome to try and
change my mind.
Thoughts?
--
Peter Geoghegan
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Add-hardening-to-catch-invalid-TIDs-from-indexes.patch | application/octet-stream | 10.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2021-11-03 04:42:03 | Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data |
| Previous Message | Peter Geoghegan | 2021-11-02 23:48:03 | Re: BUG #17245: Index corruption involving deduplicated entries |