Re: [BUG]Update Toast data failure in logical replication

From: Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUG]Update Toast data failure in logical replication
Date: 2021-06-02 13:50:35
Message-ID: CAGz5QCLND451Rc4iu9LsXLTOUV+z5nWNabOOaDzdBrQqAC+jEw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 2, 2021 at 3:10 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> Yes, you are right. I will change it in the next version, along with
> the test case.
>
+ /*
+ * if the key hasn't changed and we're only logging the key, we're done.
+ * But if tuple has external data then we might have to detoast the key.
+ */
This doesn't really mention why we need to detoast the key even when
the key remains the same. I guess we can add some more details here.

--
Thanks & Regards,
Kuntal Ghosh

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2021-06-02 13:53:16 Re: [BUG]Update Toast data failure in logical replication
Previous Message Jim Mlodgenski 2021-06-02 13:38:39 Support for CREATE MODULE?