| From: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nikolay Shaplov <dhyan(at)nataraj(dot)su> |
| Subject: | Re: Custom reloptions and lock modes |
| Date: | 2019-09-20 07:10:51 |
| Message-ID: | CAGz5QCJv4RmRL8Amdx-R1PQ0mb5hzNcaUneEZ_sHcFu_xsfG6A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 20, 2019 at 12:38 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> > One small thing:
> >
> > add_int_reloption(bl_relopt_kind, buf,
> > "Number of bits generated for each index column",
> > - DEFAULT_BLOOM_BITS, 1, MAX_BLOOM_BITS);
> > + DEFAULT_BLOOM_BITS, 1, MAX_BLOOM_BITS,
> > + AccessExclusiveLock);
> > Do we need a comment to explain why we're using AccessExclusiveLock in
> > this case?
>
> Because that's the safest default to use here? That seemed obvious to
> me.
Okay. Sounds good.
--
Thanks & Regards,
Kuntal Ghosh
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-09-20 07:15:28 | Re: backup manifests |
| Previous Message | Michael Paquier | 2019-09-20 07:08:52 | Re: Custom reloptions and lock modes |