Re: [HACKERS] Two phase commit in ECPG

From: Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
To: Michael Meskes <meskes(at)postgresql(dot)org>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: [HACKERS] Two phase commit in ECPG
Date: 2017-03-17 09:17:56
Message-ID: CAGz5QC+0-dPU1Ggf7121ePbEOyV9nAt2veZv+Tu3dSsqXmhvNg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Tue, Mar 14, 2017 at 1:35 AM, Michael Meskes <meskes(at)postgresql(dot)org> wrote:
>> Previous 002 patch lacked to add describing PREPARE TRANSACTION.
>> Attached updated 002 patch.
>
> I just committed both patches and a backport of the bug fix itself.
> Thanks again for finding and fixing.
Regression tests for sql/twophase is failing while performing the test
with make installcheck.
+ [NO_PID]: ecpg_check_PQresult on line 32: bad response - ERROR:
prepared transactions are disabled
+ HINT: Set max_prepared_transactions to a nonzero value.

Setting max_prepared_transactions accordingly fixes the issue. But,
I'm not sure whether this test should be performed by installcheck by
default or should only be performed by make
installcheck-prepared-txns.

--
Thanks & Regards,
Kuntal Ghosh
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Heikki Linnakangas 2017-03-17 09:19:22 Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
Previous Message Kyotaro HORIGUCHI 2017-03-17 07:48:27 Re: [BUGS] Bug in Physical Replication Slots (at least 9.5)?

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2017-03-17 09:18:54 pgsql: Fix and simplify check for whether we're running as Windows serv
Previous Message Dave Page 2017-03-17 09:00:51 Re: pg_ls_waldir() & pg_ls_logdir()