| From: | Todd Sedano <tsedano(at)pivotal(dot)io> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Removes uninitialized variable compiler warning |
| Date: | 2017-03-21 23:00:23 |
| Message-ID: | CAGqMwaDoOm5iB+4_p_YG3cPNDoEH1sLV3s3o82=AkWfmPsseUA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
We can disregard this patch. It appears that PointerGetDatum initializes
lenlemm.
On Mon, Mar 20, 2017 at 10:04 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Todd Sedano <tsedano(at)pivotal(dot)io> writes:
> > This patch removes a compiler warning.
> > warning: variable 'lenlemm' is uninitialized when used here
> > [-Wuninitialized]
>
> Hm, on what compiler? AFAICS, that parsetext() function hasn't
> changed meaningfully since 2007, and nobody complained of
> uninitialized-variable warnings in it before.
>
> We're generally willing to try to silence such warnings on mainstream
> compilers, but not on weird ones ...
>
> regards, tom lane
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-03-21 23:10:39 | Re: increasing the default WAL segment size |
| Previous Message | Peter Eisentraut | 2017-03-21 22:59:57 | Re: increasing the default WAL segment size |