From: | Jesse Zhang <sbjesse(at)gmail(dot)com> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Cc: | Noah Misch <noah(at)leadboat(dot)com> |
Subject: | Header / Trailer Comment Typos for M4 macros |
Date: | 2020-04-22 14:17:05 |
Message-ID: | CAGf+fX7DDyq6WfCy6X_KtD28MkbNBE6NkRi26fSf25dfUwX0zw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi hackers,
While poking at the build system I stumbled upon some trivial trailer
comment inconsistencies in config/c-compiler.m4. They can be fixed
either way: either changing the macro names or changing the comment. PFA
a patch that keeps the macro names.
In hindsight though, it seems that PGAC_PRINTF_ARCHETYPE was meant to be
PGAC_C_PRINTF_ARCHETYPE, judging by a half-second squint of surrounding,
similar macros. Thoughts?
Also in hindsight: it seems that, as suggested in the trailer typo,
PGAC_PROG_CXX_VAR_OPT (a la the C version PGAC_PROG_CC_VAR_OPT) would be
a good addition if we ever want to add the negative warning flags (for
starter, Wno-unused-command-line-argument for clang++) to CXXFLAGS, but
I assume it wasn't there in the final patch because we didn't use it
(presumably because the patch was minimized?). Thoughts?
Cheers,
Jesse
Attachment | Content-Type | Size |
---|---|---|
0001-Fix-header-trailer-typos-for-m4-macros.patch | application/x-patch | 1.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-04-22 14:17:26 | Re: HEAPDEBUGALL is broken |
Previous Message | Jehan-Guillaume de Rorthais | 2020-04-22 14:14:20 | Re: [BUG] non archived WAL removed during production crash recovery |