From: | Jesse Zhang <sbjesse(at)gmail(dot)com> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Fix header identification |
Date: | 2020-07-13 16:31:58 |
Message-ID: | CAGf+fX4-8xULEOz09DE2dZGjT+q8VJ--rqfTpvcFwc+A4fc-3Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi hackers,
PFA a patch that fixes up the identification for 4 header files.
I did a little archaeology trying to find plausible reasons for why we
committed the wrong identification in the first place, and here's what I
came up with:
jsonfuncs.h was created in ce0425b162d0a to house backend-only json
function declarations previously in jsonapi.h, and the identification
was a copy-pasta from jsonapi.h (then in src/include/utils).
jsonapi.h was wholesale moved to common in beb4699091e9f without
changing identification.
partdesc.h was created in 1bb5e78218107 but I can't find a good excuse
why we made a mistake then, except for (maybe) the prototype for
RelationBuildPartitionDesc() was moved from partcache.h and so we may
have also taken its identification line, although that sounds arbitrary.
llvmjit_emit.h was created with the wrong identification, probably due
to a personal template...
Cheers,
Jesse
Attachment | Content-Type | Size |
---|---|---|
0001-Fix-header-identification.patch | text/x-patch | 2.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2020-07-13 16:47:36 | Re: Default setting for enable_hashagg_disk |
Previous Message | Peter Geoghegan | 2020-07-13 16:20:32 | Re: Default setting for enable_hashagg_disk |