Re: Ambiguous description on new columns

Yes, this change is clear to me that the "columns added" applies to the
table on the publisher.

Regards,
Koen De Groote

On Tue, Jun 4, 2024 at 7:57 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:

> On Fri, May 31, 2024 at 10:54 PM Peter Smith <smithpb2250(at)gmail(dot)com>
> wrote:
> >
> > On Wed, May 29, 2024 at 8:04 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > >
> > > > >
> > > > > The following documentation comment has been logged on the website:
> > > > >
> > > > > Page:
> https://www.postgresql.org/docs/16/logical-replication-col-lists.html
> > > > > Description:
> > > > >
> > > > > The documentation on this page mentions:
> > > > >
> > > > > "If no column list is specified, any columns added later are
> automatically
> > > > > replicated."
> > > > >
> > > > > It feels ambiguous what this could mean. Does it mean:
> > > > >
> > > > > 1/ That if you alter the table on the publisher and add a new
> column, it
> > > > > will be replicated
> > > > >
> > > > > 2/ If you add a column list later and add a column to it, it will
> be
> > > > > replicated
> > > > >
> > > > > In both cases, does the subscriber automatically create this
> column if it
> > > > > wasn't there before?
> > > >
> > > > ~~~~
> > > >
> > > > I think the following small change will remove any ambiguity:
> > > >
> > > > BEFORE
> > > > If no column list is specified, any columns added later are
> > > > automatically replicated.
> > > >
> > > > SUGGESTION
> > > > If no column list is specified, any columns added to the table later
> > > > are automatically replicated.
> > > >
> > > > ~~
> > > >
> > > > I attached a small patch to make the above change.
> > >
> > > A small recommendation:
> > > It would enhance clarity to include a line break following "If no
> > > column list is specified, any columns added to the table later are":
> > > - If no column list is specified, any columns added later are
> automatically
> > > + If no column list is specified, any columns added to the table
> > > later are automatically
> > > replicated. This means that having a column list which names all
> columns
> >
> > Hi Vignesh,
> >
> > IIUC you're saying my v1 patch *content* and rendering is OK, but you
> > only wanted the SGML text to have better wrapping for < 80 chars
> > lines. So I have attached a patch v2 with improved wrapping. If you
> > meant something different then please explain.
> >
>
> Your patch is an improvement. Koen, does the proposed change make
> things clear to you?
>
> --
> With Regards,
> Amit Kapila.
>