From: | Steve Chavez <steve(at)supabase(dot)io> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: 'converts internal representation to "..."' comment is confusing |
Date: | 2023-06-24 20:52:11 |
Message-ID: | CAGRrpzbBuQEGB7irJDpTegjdr29RpMKz-Kx0YocDdSRGAKDWJQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello hackers,
Tom, could we apply this patch since Robert agrees it's an improvement?
Best regards,
Steve
On Tue, 16 May 2023 at 07:49, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Sun, May 14, 2023 at 9:37 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Steve Chavez <steve(at)supabase(dot)io> writes:
> > > I found "..." confusing in some comments, so this patch changes it to
> > > "cstring". Which seems to be the intention after all.
> >
> > Those comments are Berkeley-era, making them probably a decade older
> > than the "cstring" pseudotype (invented in b663f3443). Perhaps what
> > you suggest is an improvement, but I'm not sure that appealing to
> > original intent can make the case.
>
> FWIW, it does seem like an improvement to me.
>
> --
> Robert Haas
> EDB: http://www.enterprisedb.com
>
From | Date | Subject | |
---|---|---|---|
Next Message | Steve Chavez | 2023-06-24 21:35:38 | Castable Domains for different JSON representations |
Previous Message | Joel Jacobson | 2023-06-24 19:16:30 | Re: Do we want a hashset type? |