Re: [PATCH] Identify LWLocks in tracepoints

On Wed, 5 May 2021 at 09:15, Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com> wrote:

>> warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
>> 1322 | TRACE_POSTGRESQL_LWLOCK_WAIT_START(T_NAME(lock), mode);
>> | ^
>
> Odd that I didn't get that.

This compiler complaint is not due to the _ENABLED() test as such.
It's due to the fact that we completely define out the
TRACE_POSTGRESQL_ macros with src/backend/utils/Gen_dummy_probes.sed .

While explicit braces could be added around each test, I suggest
fixing Gen_dummy_probes.sed to emit the usual dummy statement instead.
Patch attached.