From: | Sarah McAlear <smcalear(at)pivotal(dot)io> |
---|---|
To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Cc: | Hao Wang <haowang(at)pivotal(dot)io> |
Subject: | [pgAdmin4][PATCH] Refactor and change of implementation of keyboard_shortcuts function dependencies |
Date: | 2017-08-03 10:08:22 |
Message-ID: | CAGRPzo9G70LPFmRkNC5awGAojA-c2_Ek0Bxui=wtkD_1pEg+aA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Hackers!
Attached is a patch that extracts the functions called by the
keyboard_shortcuts function extracted earlier from sqlEditor. This includes
- executeQuery
- explainAnalyze
- explain
- download
- commentBlockCode
- commentLineCode
- uncommentLineCode
There is still more work to be done, but this is it for now.
There is also an additional patch that changes the implementation of the
commentLineCode, uncommentLineCode, and commentBlockCode functions. The
shortcut
- for commentLineCode is now cmd + / (ctrl + / for Windows)
- for uncommentLineCode cmd + . (ctrl + . for Windows)
- for comment and uncomment blockCode shift + cmd + / (shift + ctrl + /
for Windows)
This is consistent with other IDEs and the way commenting is implemented.
Thanks!
Hao & Sarah
Attachment | Content-Type | Size |
---|---|---|
1_refactor_keyactions.diff | text/plain | 302.9 KB |
2_change_keyboard_shortcuts_for_commenting.diff | text/plain | 6.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2017-08-03 11:21:23 | Re: [pgAdmin4][Patch]: To fix Collation tests |
Previous Message | Murtuza Zabuawala | 2017-08-03 09:11:57 | [pgAdmin4][Patch]: Use the correct resultset type for Type module |