Re: [pgAdmin4][Patch]: UI improvements in data-grid/query tool

From: Sarah McAlear <smcalear(at)pivotal(dot)io>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Shirley Wang <swang(at)pivotal(dot)io>
Subject: Re: [pgAdmin4][Patch]: UI improvements in data-grid/query tool
Date: 2017-06-08 14:07:19
Message-ID: CAGRPzo9EJkPQR7NnmrrNoi3Pmve5Se=TWyOy1qm0MRkpaceQcg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Surinder!

We reviewed the patch and the changes look great. Could you change the
grays to match the style guide?

Silver, #222, and #aaa aren't listed in pgadmin.style.css.

Thanks so much!
Shirley & Sarah

On Thu, Jun 8, 2017 at 9:34 AM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:

> Hi,
>
> *Changes:*
>
> 1) Display only border-top for data-grid header instead of border on whole
> data-grid.
>
> 2) Remove dotted border from cell right for consistency.
>
> 3) Add border-bottom for header-row so that on scroll to bottom header
> rows are differentiated from cells.
>
> Also, due to these changes, the vertical scrollbar which appears at
> data-grid right side seems to fixed.
>
> PFA patch and review.
>
>
> Thanks,
> Surinder
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-06-08 14:19:33 Re: [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience
Previous Message Atul Sharma 2017-06-08 14:03:44 [pgAdmin4][Patch][RM_2450] : Internal Server Error displayed if click on statistic tab for PG 10 server