Re: Support NOT VALID / VALIDATE constraint options for named NOT NULL constraints

Hi Alvaro,

Here are the latest patches, which includes the regression fix.

Thanks,

On Wed, Mar 12, 2025 at 3:38 PM Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
wrote:

> On Wed, Mar 12, 2025 at 3:20 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
> wrote:
> >
> > On 2025-Mar-12, Ashutosh Bapat wrote:
> >
> > > If the test passes for you, can you please try the patches at [1] on
> > > top of your patches? Please apply those, set and export environment
> > > variable PG_TEST_EXTRA=regress_dump_test, and run 002_pg_upgrade test?
> > > I intended to do this but can not do it since the test always fails
> > > with your patches applied.
> >
> > Oh, I need to enable a PG_TEST_EXTRA option in order for the test to
> > run? FFS. That explains why the tests passed just fine for me.
> > I'll re-run.
>
> You need PG_TEST_EXTRA to run the testcase I am adding there. Rest of
> the testcases run without PG_TEST_EXTRA.
>
> --
> Best Wishes,
> Ashutosh Bapat
>

--
Rushabh Lathia