| From: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Why can't we used CAPITAL LETTERS into replication slot_name? |
| Date: | 2015-09-25 12:09:41 |
| Message-ID: | CAGPqQf15vQCbff+USVqA_iW+VQ4q7s2DjMctHOhcejCyHSCtHQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks Andres.
PFA patch to fix the hint message.
On Fri, Sep 25, 2015 at 5:34 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Hi,
>
> On 2015-09-25 17:32:39 +0530, Rushabh Lathia wrote:
> > I am just wondering why pg_create_physical_replication_slot() can't take
> > CAPITAL LETTERS into slot_name ?
>
> Windows. And OSX. Specifically case-insensitive filenames.
>
> > If its by design then was should atleast change the hint into
> > ReplicationSlotValidateName() which says: "Replication slot names may
> only
> > contain letters, numbers, and the underscore character."
>
> We could add a 'lower case' in there.
>
> Greetings,
>
> Andres Freund
>
Regards,
Rushabh Lathia
www.EnterpriseDB.com
| Attachment | Content-Type | Size |
|---|---|---|
| slot_name_hint_message_change.patch | application/x-download | 638 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2015-09-25 12:51:31 | Re: DBT-3 with SF=20 got failed |
| Previous Message | Andres Freund | 2015-09-25 12:04:52 | Re: Why can't we used CAPITAL LETTERS into replication slot_name? |