| From: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | incorrect error message, while dropping PROCEDURE |
| Date: | 2017-12-14 04:31:18 |
| Message-ID: | CAGPqQf0chhf9A7X2F2Eko-JzrVemOsgSM=C=6Pg0xtyHeJocPA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Currently if some one try to drop the PROCEDURE and
it don't have privilege or it's not an owner, than error message
still indicate object as FUNCTION.
Example:
postgres(at)37737=#drop procedure pro;
ERROR: must be owner of function pro
This doesn't look correct specially that now we have separate
object type as OBJECT_PROCEDURE. It seems like we need
to introduce new AclObjectKind for PROCEDURE and do the
necessary changes to pass the correct AclObjectKind.
PFA patch, where introduced new AclObjectKind (ACL_KIND_PROCEDURE),
msg for the new AclObjectKind, and passed it through at
appropriate places.
Also update the necessary "make check" expected output changes.
Regards,
Thanks,
Rushabh Lathia
www.EnterpriseDB.com
| Attachment | Content-Type | Size |
|---|---|---|
| AclObjectKind_procedure.patch | text/x-patch | 4.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2017-12-14 05:23:59 | pg_(total_)relation_size and partitioned tables |
| Previous Message | Kyotaro HORIGUCHI | 2017-12-14 04:20:07 | Re: Protect syscache from bloating with negative cache entries |