"ALTER TRIGGER .. RENAME TO" broken with the "Remove WITH OIDS" commit.

From: Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Andres Freund <andres(at)anarazel(dot)de>
Subject: "ALTER TRIGGER .. RENAME TO" broken with the "Remove WITH OIDS" commit.
Date: 2019-01-21 11:32:15
Message-ID: CAGPqQf04PywZX3sVQaF6H=oLiW9GJncRW+=e78vTy4MokEWcZw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I found that ALTER TRIGGER .. RENAME TO is broken and it's
unable to rename the trigger. Looking further seems renametrig()
function, copy the new trigger name into wrong tuple. This is
broken with below commit:

commit 578b229718e8f15fa779e20f086c4b6bb3776106
Author: Andres Freund <andres(at)anarazel(dot)de>
Date: Tue Nov 20 15:36:57 2018 -0800

Remove WITH OIDS support, change oid catalog column visibility.

PFA patch to fix the issue. I also added the testcase for the
same into the regression.

regards,
Rushabh Lathia
www.EnterpriseDB.com

Attachment Content-Type Size
alter_trigger_rename.patch text/x-patch 2.6 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Arthur Zakirov 2019-01-21 11:51:49 Re: [PROPOSAL] Shared Ispell dictionaries
Previous Message Amit Kapila 2019-01-21 11:31:55 Re: WIP: Avoid creation of the free space map for small tables