Re: cache lookup failed error for partition key with custom opclass

From: Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: cache lookup failed error for partition key with custom opclass
Date: 2017-07-25 05:41:09
Message-ID: CAGPqQf0=p9D4oPS2uhqztn00ZBgpCdLrN_AXwO0AwnN6-n7RbQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 24, 2017 at 7:23 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> writes:
> > PFA patch, where added elog() to add the error message same as all other
> > places.
>
> Some looking around says that this *isn't* the only place that just
> blithely assumes that it will find an opfamily entry. But I agree
> that not checking for that isn't up to project standards.
>

Thanks Tom.

I go thorough the get_opfamily_proc() in the system and added the
check for InvalidOid.

Thanks,
Rushabh Lathia
www.EnterpriseDB.com

Attachment Content-Type Size
cache_lookup_fail_v2.patch text/x-patch 2.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zehra Gül Çabuk 2017-07-25 06:18:29 Postgresql “alter column type” creates an event which contains “temp_table_xxx”
Previous Message Rafia Sabih 2017-07-25 05:31:04 Re: Partition-wise join for join between (declaratively) partitioned tables