| From: | Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> |
|---|---|
| To: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Align memory context level numbering in pg_log_backend_memory_contexts() |
| Date: | 2025-04-17 11:05:42 |
| Message-ID: | CAGPVpCSuZuhrevxCDcbFMLXfHyxk2Nz5AXbAE1ReTL5+_f+fxw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, 17 Nis 2025 Per, 12:35 tarihinde
şunu yazdı:
> I guess few people would notice this difference, but I think it's better
> to avoid changing it unless there's a good reason to do so.
> Personally, I also feel the original formatting better -- especially
> because the "xx more child contexts..." line is aligned with the other
> child contexts at the same level.
>
> Attached a v2 patch to restore the original indentation.
> What do you think?
>
Thanks for noticing the issue. I also agree with you all about using
1-based levels consistently in memory context outputs
including pg_log_backend_memory_contexts.
I reviewed and tested the v2 patch and LGTM.
Regards,
--
Melih
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Konstantin Knizhnik | 2025-04-17 11:21:07 | Re: Changing shared_buffers without restart |
| Previous Message | Daniel Gustafsson | 2025-04-17 11:01:20 | Re: pg_dump: Fix dangling pointer in EndCompressorZstd() |