| From: | Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, "Wei Wang (Fujitsu)" <wangw(dot)fnst(at)fujitsu(dot)com>, "Yu Shi (Fujitsu)" <shiy(dot)fnst(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication |
| Date: | 2023-07-20 11:42:29 |
| Message-ID: | CAGPVpCQ=PZkSWANLmW06GRJsSuUfYtMjw8y5TJnbq415o6e9og@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Peter Smith <smithpb2250(at)gmail(dot)com>, 20 Tem 2023 Per, 05:41 tarihinde şunu
yazdı:
> 7. InitializeLogRepWorker
>
> if (am_tablesync_worker())
> ereport(LOG,
> - (errmsg("logical replication worker for subscription \"%s\", table
> \"%s\" has started",
> + (errmsg("logical replication worker for subscription \"%s\", table
> \"%s\" with relid %u has started",
> MySubscription->name,
> - get_rel_name(MyLogicalRepWorker->relid))));
> + get_rel_name(MyLogicalRepWorker->relid),
> + MyLogicalRepWorker->relid)));
>
> But this is certainly a tablesync worker so the message here should
> say "logical replication table synchronization worker" like the HEAD
> code used to do.
>
> It seems this mistake was introduced in patch v20-0001.
>
I'm a bit confused here. Isn't it decided to use "logical replication
worker" regardless of the worker's type [1]. That's why I made this change.
If that's not the case here, I'll put it back.
Thanks,
--
Melih Mutlu
Microsoft
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2023-07-20 11:46:19 | Re: POC: GROUP BY optimization |
| Previous Message | Tomas Vondra | 2023-07-20 11:35:40 | Re: Use of additional index columns in rows filtering |