| From: | Oliver Ford <ojford(at)gmail(dot)com> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
| Cc: | krasiyan(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, vik(at)postgresfriends(dot)org, pgsql-hackers(at)postgresql(dot)org, andrew(at)tao11(dot)riddles(dot)org(dot)uk, david(at)fetter(dot)org |
| Subject: | Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options |
| Date: | 2025-02-18 16:50:30 |
| Message-ID: | CAGMVOdvtAEvv3KgkFoa2W5-vpz--QEvrVbvS84ZikcCb-SyA6g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 18, 2025 at 4:19 AM Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
> > Attached version doesn't use the nonnulls array if an Exclude is
> > specified, as I think it's not going to work with exclusions (as it's
> > only an optimization, this is ok and can be taken out entirely if you
> > prefer). I've also added your tests above to the tests.
>
> I applied the v7 patch and ran regression and tap test. There was no
> errors. Great!
>
> BTW, I noticed that in the code path where
> ignorenulls_getfuncarginframe() is called, WinSetMarkPosition() is
> never called?
>
> Attached version uses the mark_pos at the end.
| Attachment | Content-Type | Size |
|---|---|---|
| 0008-ignore.patch | application/octet-stream | 50.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-02-18 16:54:45 | Re: BUG #18815: Logical replication worker Segmentation fault |
| Previous Message | Tom Lane | 2025-02-18 16:30:02 | Re: Clarification on Role Access Rights to Table Indexes |