Re: Add RANGE with values and exclusions clauses to the Window Functions

From: Oliver Ford <ojford(at)gmail(dot)com>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Erik Rijkers <er(at)xs4all(dot)nl>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add RANGE with values and exclusions clauses to the Window Functions
Date: 2018-02-02 17:31:32
Message-ID: CAGMVOduKGh6dazo-iyfYDvVRm_rv9ZorPLyE40daDyGR-w6vvg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 2, 2018 at 4:57 PM, David G. Johnston
<david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
> On Fri, Feb 2, 2018 at 9:26 AM, Oliver Ford <ojford(at)gmail(dot)com> wrote:
>>
>> On Thu, Feb 1, 2018 at 1:46 AM, David G. Johnston
>> <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
>>
>> > The three callers of WinGetFuncArgInFrame don't use the isout argument;
>> > they
>> > probably need to read that and a new isexcluded argument. Start at the
>> > head, loop until isout = true || isexcluded = false.
>>
>> The patch takes a slightly different approach and puts the logic in
>> WinGetFuncArgInFrame.
>> The "row_is_in_frame" function now returns a specific return code for
>> when an Exclude
>> clause was matched.
>
>
> I would suggest adding constants for the 4 possible results from
> row_is_in_frame.
>
> David J.
>

New defines for these in the attached patch.

Attachment Content-Type Size
0001-window-frame-v13.patch application/octet-stream 174.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-02-02 18:37:11 pgsql: Support parallel btree index builds.
Previous Message David G. Johnston 2018-02-02 16:57:49 Re: Add RANGE with values and exclusions clauses to the Window Functions