From: | Brian Cosgrove <cosgroveb(at)gmail(dot)com> |
---|---|
To: | Christoph Berg <cb(at)df7cb(dot)de>, Bradford Boyle <bradford(dot)d(dot)boyle(at)gmail(dot)com>, pgsql-pkg-debian(at)postgresql(dot)org |
Subject: | Re: PgBouncer 1.24.0 - New upstream version |
Date: | 2025-02-05 12:40:41 |
Message-ID: | CAGKCzNCKAEEJmd5Fn5Be4zu1YxS9okBoeqBX15_RijvBgouqzA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-pkg-debian |
Skipping this release for bullseye is not entirely unreasonable with Trixie
pending.
Skipping the entire suite feels unreasonable if the Postgres Debian team
releases 1.24.
I am working up a patch that will skip only these tests that will likely be
accepted upstream as well, should Debian choose to release 1.24 for
bullseye.
https://github.com/pgbouncer/pgbouncer/pull/1266
On Wed, Feb 5, 2025 at 3:10 AM Christoph Berg <cb(at)df7cb(dot)de> wrote:
> Re: Bradford Boyle
> > I think we could go without tests on bullseye since it seems like we are
> > nearing the trixie release and bullseye will become old old stable.
> > (Correct me if I am wrong on this point, I'm making this assumption
> > based on the trixie freeze dates). There's probably little value in
> > creating extra work here.
>
> Or we just don't update the package on bullseye, leaving it at 1.23.1.
> But there is still the autopkgtest, so we still have test coverage
> there.
>
> > It looks like d/rules for pgbouncer will skip the tests if nocheck is in
> > DEB_BUILD_OPTIONS -- is this something that can be configured via the
> Jenkins
> > YAML? I am not very familiar with the Jenkins job builder YAML and I
> didn't see
> > any usages of that in the current set of jobs. Or would I need to update
> > generate-pgdg-source to include an additional tweak to disable the tests
> on
> > older platforms?
>
> Any of these would work.
>
> DEB_BUILD_OPTIONS=nocheck would have to be set in the sbuild-package
> script. That's probably the easiest way forward.
>
> The extra test dependencies need annotating with <!nocheck> so the
> build doesn't try to install them.
>
> Christoph
>
>
>
--
Brian Cosgrove
From | Date | Subject | |
---|---|---|---|
Next Message | Brian Cosgrove | 2025-02-05 17:01:39 | Re: PgBouncer 1.24.0 - New upstream version |
Previous Message | Christoph Berg | 2025-02-05 09:09:51 | Re: PgBouncer 1.24.0 - New upstream version |