Re: PgBouncer 1.24.0 - New upstream version

Thanks for the heads up, Bradford.
https://github.com/pgbouncer/pgbouncer/pull/1250

On Mon, Jan 20, 2025 at 11:55 PM Brian Cosgrove <cosgroveb(at)gmail(dot)com> wrote:

> Ah, funny, we (pgbouncer) just started pinning this in requirements.txt
> because of this failure:
> https://github.com/pgbouncer/pgbouncer/commit/0cf59fadc0671a7363afa51086631b87a26893dc
>
> On Mon, Jan 20, 2025 at 11:38 PM Brian Cosgrove <cosgroveb(at)gmail(dot)com>
> wrote:
>
>> I think this note in the psycopg 3.2.4 news is what we're seeing in the
>> pgbouncer tests:
>> https://github.com/psycopg/psycopg/compare/3.2.3...3.2.4#diff-87f7a7bb7fe8dbed76e16b67b87f27bda7b779b56e7d93ed3350d77ee4a3f217R20-R23
>>
>>
>> On Mon, Jan 20, 2025 at 11:25 PM Brian Cosgrove <cosgroveb(at)gmail(dot)com>
>> wrote:
>>
>>> Yes, please do. A Postgres client package (psycopg) update causing
>>> failing integration tests seems highly unlikely to be a genuine issue for
>>> the pgbouncer.
>>>
>>> I also reproduced locally the failures you're seeing on Salsa. I notice
>>> that there are relevant changes in psycopg 3.2.4 and I think that there are
>>> some assertions needing updates in the upstream project.
>>>
>>> I'll file an issue with pgbouncer but for now please unblock the upload.
>>>
>>> On Mon, Jan 20, 2025 at 10:42 PM Bradford Boyle <
>>> bradford(dot)d(dot)boyle(at)gmail(dot)com> wrote:
>>>
>>>> Hi Brian,
>>>>
>>>> I was looking at the package for pgBouncer 1.24.0 again today and it
>>>> looks like the tests are failing [0]. After reading through the logs, it
>>>> looks like psycopg in testing and unstable was updated to 3.2.4 this
>>>> past Friday. I am able to reproduce the test failures in dev environment
>>>> by updating the version in requirements.txt. Should we disable the main
>>>> test suite for now to unblock the upload of 1.24.0?
>>>>
>>>> Regards,
>>>>
>>>> --Bradford
>>>>
>>>> [0]: https://salsa.debian.org/postgresql/pgbouncer/-/jobs/6962351
>>>>
>>>
>>>
>>> --
>>> Brian Cosgrove
>>>
>>
>>
>> --
>> Brian Cosgrove
>>
>
>
> --
> Brian Cosgrove
>

--
Brian Cosgrove