Re: Changing baserel to foreignrel in postgres_fdw functions

On Wed, Nov 22, 2023 at 3:27 AM Bruce Momjian <bruce(at)momjian(dot)us> wrote:

>
> Should this patch be applied?

I think so.

> ---------------------------------------------------------------------------
>
> On Thu, Feb 15, 2018 at 06:57:50PM +0530, Ashutosh Bapat wrote:
> > Hi,
> > I noticed that functions is_foreign_expr(), classifyConditions() and
> > appendOrderByClause() had variables/arguments named baserel when the
> > relations passed to those could be join or upper relation as well.
> > Here's patch renaming those as foreignrel.
>

The patch is more than 5 years old. So it might need adjustments. E.g. the
appendOrderByClause() does not require the change anymore. But the other
two functions still require the changes. There may be other new places that
require change. I have not checked that. If we are accepting this change, I
can update the patch.

--
Best Wishes,
Ashutosh