| From: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Diagnostic comment in LogicalIncreaseXminForSlot |
| Date: | 2021-09-06 11:59:16 |
| Message-ID: | CAGEoWWQFJAqhw1a512cHW+kiv8QS1usHeYSvEsZrqw2snB5dVw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Yeah, I agree. Sorry for missing that.
The updated patch looks good to me.
On Mon, Sep 6, 2021 at 3:25 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Tue, Aug 17, 2021 at 11:58 AM Ashutosh Bapat
> <ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
> >
> > Hi Amit and Andres,
> > Here's updated patch
> >
>
> I think we can log the required information immediately after
> releasing spinlock, otherwise, the other logs from
> LogicalConfirmReceivedLocation() might interleave. I have made that
> change and slightly edit the comment and commit message. I am planning
> to push this tomorrow unless you or others have any comments.
>
> --
> With Regards,
> Amit Kapila.
>
--
--
Best Wishes,
Ashutosh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2021-09-06 12:28:20 | Re: Allow escape in application_name |
| Previous Message | Dilip Kumar | 2021-09-06 11:54:59 | Re: [BUG] Failed Assertion in ReorderBufferChangeMemoryUpdate() |