| From: | Jelte Fennema-Nio <me(at)jeltef(dot)nl> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, Tristen Raab <tristen(dot)raab(at)highgo(dot)ca>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jelte Fennema <github-tech(at)jeltef(dot)nl> |
| Subject: | Re: Allow specifying a dbname in pg_basebackup connection string |
| Date: | 2024-11-04 18:20:59 |
| Message-ID: | CAGECzQTwvS_RZi347j2sbUhe2ieaz-tKe=pQu+=h5iftPkSJfQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 4 Nov 2024 at 18:14, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> perhaps under the illusion that dbname and connection_string can't
> both be NULL.
Yeah, I'm pretty sure I didn't realise that was an option. I think I
probably misinterpreted this comment (might be nice to clarify there
that both being NULL is also a valid option):
/* pg_recvlogical uses dbname only; others use connection_string only. */
Assert(dbname == NULL || connection_string == NULL);
> I think the attached will fix it, but I wonder if there are edge
> cases I'm not thinking of.
Yeah that patch looks good to me. Reading the patch carefully again I
cannot think there are other changes in behaviour (except the ones
intended by the change).
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2024-11-04 18:23:20 | Re: Fix a typo in the comment of gistdoinsert() |
| Previous Message | Robert Haas | 2024-11-04 17:53:05 | pg_combinebackup --incremental |