Re: [EXTERNAL] Re: Add non-blocking version of PQcancel

From: Jelte Fennema <postgres(at)jeltef(dot)nl>
To: Greg Stark <stark(at)mit(dot)edu>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Jelte Fennema <Jelte(dot)Fennema(at)microsoft(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Jacob Champion <jchampion(at)timescale(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [EXTERNAL] Re: Add non-blocking version of PQcancel
Date: 2023-03-22 12:32:30
Message-ID: CAGECzQTaGtAWmM98q9uup2pjODR8WSOsF_UV3YG7THoqatJApA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Rebased after conflicts with bfc9497ece01c7c45437bc36387cb1ebe346f4d2

Also included the fix for feedback from Daniel on patch 2, which he
had shared in the load balancing thread.

On Wed, 15 Mar 2023 at 09:49, Jelte Fennema <postgres(at)jeltef(dot)nl> wrote:
>
> The rebase was indeed trivial (git handled everything automatically),
> because my first patch was doing a superset of the changes that were
> committed in b6dfee28f. Attached are the new patches.
>
> On Tue, 14 Mar 2023 at 19:04, Greg Stark <stark(at)mit(dot)edu> wrote:
> >
> > On Tue, 14 Mar 2023 at 13:59, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > >
> > > "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com> writes:
> > > > It looks like this needs a big rebase in fea-uth.c fe-auth-scram.c and
> > > > fe-connect.c. Every hunk is failing which perhaps means the code
> > > > you're patching has been moved or refactored?
> > >
> > > The cfbot is giving up after
> > > v14-0001-libpq-Run-pgindent-after-a9e9a9f32b3.patch fails,
> > > but that's been superseded (at least in part) by b6dfee28f.
> >
> > Ah, same with Jelte Fennema's patch for load balancing in libpq.
> >
> > --
> > greg

Attachment Content-Type Size
v16-0003-Return-2-from-pqReadData-on-EOF.patch application/octet-stream 4.3 KB
v16-0005-Start-using-new-libpq-cancel-APIs.patch application/octet-stream 9.2 KB
v16-0002-Refactor-libpq-to-store-addrinfo-in-a-libpq-owne.patch application/octet-stream 11.6 KB
v16-0001-libpq-Run-pgindent-after-a9e9a9f32b3.patch application/octet-stream 22.4 KB
v16-0004-Add-non-blocking-version-of-PQcancel.patch application/octet-stream 44.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2023-03-22 12:48:49 Re: generic plans and "initial" pruning
Previous Message Tatsuo Ishii 2023-03-22 12:32:26 Re: Doc: Improve note about copying into postgres_fdw foreign tables in batch