| From: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Joel Jacobson <joel(at)compiler(dot)org>, Gabriele Bartolini <gabriele(dot)bartolini(at)enterprisedb(dot)com>, Magnus Hagander <magnus(dot)hagander(at)redpill-linpro(dot)com>, Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com> |
| Subject: | Re: Possibility to disable `ALTER SYSTEM` |
| Date: | 2024-03-27 23:47:46 |
| Message-ID: | CAGECzQTaCifjFT3dL-VYptdZa=O51b+gBStrWsKdANHy_f3fmw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 27 Mar 2024 at 23:06, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > > > > + some outside mechanism. In such environments, using <command>ALTER
> > > > > + SYSTEM</command> to make configuration changes might appear to work,
> > > > > + but then may be discarded at some point in the future when that outside
> > > >
> > > > "might"
> > >
> > > This does not seem like a mistake to me. I'm not sure why you think it is.
> >
> > I also think the original sentence was correct, but I don't think it
> > read very naturally. Changed it now in hopes to improve that.
>
> So, might means "possibility" while "may" means permission, so "might"
> is clearer here.
Aaah, I misunderstood your original feedback then. I thought you
didn't like the use of "might" in "might appear to work". But I now
realize you meant "may be discarded" should be changed to "might be
discarded". I addressed that in my latest version of the patch.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2024-03-27 23:50:09 | Fix some resources leaks (src/bin/pg_basebackup/pg_createsubscriber.c) |
| Previous Message | David Rowley | 2024-03-27 23:46:28 | Re: Crash on UNION with PG 17 |