| From: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Make query cancellation keys longer |
| Date: | 2024-07-04 10:50:20 |
| Message-ID: | CAGECzQTNSSN4di_J10mXaanZKnTvONAYxVBpPPdssupQ22xSpA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 4 Jul 2024 at 12:35, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>
> On 04/07/2024 13:32, Heikki Linnakangas wrote:
> > Here's a new version of the first patch.
>
> Sorry, forgot attachment.
It seems you undid the following earlier change. Was that on purpose?
If not, did you undo any other earlier changes by accident?
> > +SendCancelRequest(int backendPID, int32 cancelAuthCode)
> >
> > I think this name of the function is quite confusing, it's not sending
> > a cancel request, it is processing one. It sends a SIGINT.
>
> Heh, well, it's sending the cancel request signal to the right backend,
> but I see your point. Renamed to ProcessCancelRequest.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Harjyot Bagga | 2024-07-04 10:56:30 | Re: Grammar guidelines in Postgres |
| Previous Message | Yugo NAGATA | 2024-07-04 10:39:31 | Re: Fix a comment on PQcancelErrorMessage |