Re: Add a GUC check hook to ensure summarize_wal cannot be enabled when wal_level is minimal

From: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add a GUC check hook to ensure summarize_wal cannot be enabled when wal_level is minimal
Date: 2024-07-10 15:08:05
Message-ID: CAGECzQTKgXGMfjWK5tnzb125AYqXnJ4jmcb7bEhyZLvHXsj4EQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 10 Jul 2024 at 16:46, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
> Do we actually need to look at pmState? Or could we just skip
> it if the context is <= PGC_S_ARGV?

I'm not 100% sure, but I think PGC_S_FILE would still be used when
postgresql.conf changes and on SIGHUP is sent. And we would want the
check_hook to be used then.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-07-10 15:11:13 Re: Add a GUC check hook to ensure summarize_wal cannot be enabled when wal_level is minimal
Previous Message David G. Johnston 2024-07-10 15:04:15 Re: Is it possible to create a cursor with hold using extended query protocol