| From: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | Yuki Seino <seinoyu(at)oss(dot)nttdata(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add “FOR UPDATE NOWAIT” lock details to the log. |
| Date: | 2025-02-12 17:31:53 |
| Message-ID: | CAGECzQSm+LLqnDJyRJONbwbOSCX57ULnMLDfSMhRR-D1nKeUbg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 12 Feb 2025 at 12:32, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> > What do you think if we simply don't log anything for SKIP LOCKED?
>
> Implementing both NOWAIT and SKIP LOCKED could take time and make the patch
> more complex. I'm fine with focusing on the NOWAIT case first as an initial patch.
I think that makes sense. It's a fairly common pattern to use SKIP
LOCKED to implement a concurrent job queue. Having such a usecase
suddenly create lots of logs seems undesirable, especially since it
created no logs at all before. Since NOWAIT already results in an
error (and thus a log), having it add some additional info seems
totally reasonable.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-02-12 17:38:21 | Re: Small memory fixes for pg_createsubcriber |
| Previous Message | Dagfinn Ilmari Mannsåker | 2025-02-12 17:29:57 | Re: Small memory fixes for pg_createsubcriber |