From: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
---|---|
To: | Gabriele Bartolini <gabriele(dot)bartolini(at)enterprisedb(dot)com> |
Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Martín Marqués <martin(dot)marques(at)gmail(dot)com>, Isaac Morland <isaac(dot)morland(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Possibility to disable `ALTER SYSTEM` |
Date: | 2024-02-07 13:49:01 |
Message-ID: | CAGECzQSNe3FVk6zKB9KE8Gi2cmWbQa9w+BkrHn1ay9aNXDuFqQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, 7 Feb 2024 at 11:35, Gabriele Bartolini
<gabriele(dot)bartolini(at)enterprisedb(dot)com> wrote:
> This is mostly the approach I have taken in the patch, except allowing to change the value in the configuration file.
(I had missed the patch in the long thread). I think it would be nice
to have this be PGC_SIGHUP, and set GUC_DISALLOW_IN_AUTO_FILE. That
way this behaviour can be changed without shutting down postgres (but
not with ALTER SYSTEM, because that seems confusing).
> but wasn't sure in which `config_group` to place the 'enable_alter_system` GUC, based on the src/include/utils/guc_tables.h. Any thoughts/hints?
I agree that none of the existing groups fit particularly well. I see
a few options:
1. Create a new group (maybe something like "Administration" or
"Enabled Features")
2. Use FILE_LOCATIONS, which seems sort of related at least.
3. Instead of adding an "enable_alter_system" GUC we would add an
"auto_config_file" guc (and use the FILE_LOCATIONS group). Then if a
user sets "auto_config_file" to an empty string, we would disable the
auto config file and thus ALTER SYSTEM.
I'd prefer 1 or 3 I think. I kinda like option 3 for its consistency
of being able to configure other config file locations, but I think
that would be quite a bit more work, and I'm not sure how useful it is
to change the location of the auto file.
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2024-02-07 13:51:53 | Re: Commitfest 2024-01 first week update |
Previous Message | David G. Johnston | 2024-02-07 13:34:06 | Re: Possibility to disable `ALTER SYSTEM` |