Re: Make query cancellation keys longer

From: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Make query cancellation keys longer
Date: 2024-03-03 06:59:15
Message-ID: CAGECzQS2+meELiT2ZwrTXvRDpnCyioPUT0Yp8htSfnaV03uykQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 1 Mar 2024 at 15:19, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> > One complication with this was that because we no longer know how long
> > the key should be, 4-bytes or something longer, until the backend has
> > performed the protocol negotiation, we cannot generate the key in the
> > postmaster before forking the process anymore.
>
> Maybe this would be easier if it's a protocol version number change,
> since that is sent earlier than protocol extensions?

Protocol version and protocol extensions are both sent in the
StartupMessage, so the same complication applies. (But I do agree that
a protocol version bump is more appropriate for this type of change)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andy Fan 2024-03-03 07:01:23 a wrong index choose when statistics is out of date
Previous Message Andy Fan 2024-03-03 06:10:57 Re: Shared detoast Datum proposal