Re: protocol-level wait-for-LSN

From: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: protocol-level wait-for-LSN
Date: 2024-10-30 09:03:27
Message-ID: CAGECzQRzd052SoYKHT1mmeNFFXP2B3wV68WgyEO7qcSAh9XErQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 28 Oct 2024 at 16:51, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> Thoughts?

+ snprintf(xloc, sizeof(xloc), "%X/%X",
LSN_FORMAT_ARGS(logptr))
+ pq_sendstring(&buf, xloc);

nit: I feel that sending the LSN as a string seems unnecessarily
wasteful of bytes. I'd rather send it as its binary representation.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema-Nio 2024-10-30 09:04:41 Re: protocol-level wait-for-LSN
Previous Message Jelte Fennema-Nio 2024-10-30 08:41:03 Re: protocol-level wait-for-LSN