| From: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add trim_trailing_whitespace to editorconfig file |
| Date: | 2024-02-15 17:47:45 |
| Message-ID: | CAGECzQRteAKaJ1jSQ+eVP3pNmO3OQcppxw5NEzA6wi5sHmR+xw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 15 Feb 2024 at 16:57, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> Is there a command-line tool to verify the syntax of .editorconfig and
> check compliance of existing files?
>
> I'm worried that expanding .editorconfig with detailed per-file rules
> will lead to a lot of mistakes and blind editing, if we don't have
> verification tooling.
I tried this one just now:
https://github.com/editorconfig-checker/editorconfig-checker.javascript
I fixed all the issues by updating my patchset to use "unset" for
insert_final_newline instead of "false".
All other files were already clean, which makes sense because the new
editorconfig rules are exactly the same as gitattributes (which I'm
guessing we are checking in CI/buildfarm). So I don't think it makes
sense to introduce another tool to check the same thing again.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0002-Require-final-newline-in-.po-files.patch | application/octet-stream | 2.0 KB |
| v3-0004-Add-note-about-keeping-.editorconfig-and-.gitattr.patch | application/octet-stream | 1.1 KB |
| v3-0001-Remove-non-existing-file-from-.gitattributes.patch | application/octet-stream | 873 bytes |
| v3-0005-Add-indent-information-about-gitattributes-to-edi.patch | application/octet-stream | 798 bytes |
| v3-0003-Bring-editorconfig-in-line-with-gitattributes.patch | application/octet-stream | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2024-02-15 17:53:10 | Re: index prefetching |
| Previous Message | Tomas Vondra | 2024-02-15 17:26:09 | Re: index prefetching |