| From: | Jelte Fennema <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Denis Laxalde <denis(dot)laxalde(at)dalibo(dot)com> |
| Cc: | Greg Stark <stark(at)mit(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Jelte Fennema <Jelte(dot)Fennema(at)microsoft(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Jacob Champion <jchampion(at)timescale(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [EXTERNAL] Re: Add non-blocking version of PQcancel |
| Date: | 2023-03-29 15:58:51 |
| Message-ID: | CAGECzQRsOobw4BYbbk08rhxG9FJRRja7=Vn9+EpYA=UG_Bd6NQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 29 Mar 2023 at 10:43, Denis Laxalde <denis(dot)laxalde(at)dalibo(dot)com> wrote:
> More importantly, not having PQcancelSend() creating the PGcancelConn
> makes reuse of that value, passing through PQcancelReset(), more
> intuitive. E.g., in the tests:
You convinced me. Attached is an updated patch where PQcancelSend
takes the PGcancelConn and returns 1 or 0.
> The thing is that we need the connection encoding (client_encoding) when
> eventually forwarding the result of PQcancelErrorMessage(), decoded, to
> the user.
Cancel connections don't have an encoding specified. They never
receive an error from the server. All errors come from the machine
that libpq is on. So I think you're making the decoding more
complicated than it needs to be.
| Attachment | Content-Type | Size |
|---|---|---|
| v18-0004-Add-non-blocking-version-of-PQcancel.patch | application/octet-stream | 44.1 KB |
| v18-0005-Start-using-new-libpq-cancel-APIs.patch | application/octet-stream | 9.2 KB |
| v18-0001-libpq-Run-pgindent-after-a9e9a9f32b3.patch | application/octet-stream | 22.4 KB |
| v18-0002-Copy-and-store-addrinfo-in-libpq-owned-private-m.patch | application/octet-stream | 11.6 KB |
| v18-0003-Return-2-from-pqReadData-on-EOF.patch | application/octet-stream | 4.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Brar Piening | 2023-03-29 16:03:48 | Re: doc: add missing "id" attributes to extension packaging page |
| Previous Message | Masahiko Sawada | 2023-03-29 15:18:04 | Re: Initial Schema Sync for Logical Replication |