| From: | Jelte Fennema-Nio <me(at)jeltef(dot)nl> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Melanie Plageman <melanieplageman(at)gmail(dot)com>, Alexander Korotkov <akorotkov(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Transform OR clauses to ANY expression |
| Date: | 2024-04-08 15:14:52 |
| Message-ID: | CAGECzQRcR68mcnkzCGh7qBQ0CAkwqS0N=Wuhx7gSM1RkVK1STg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Mon, 8 Apr 2024 at 17:10, Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
>
> On Mon, Apr 8, 2024 at 1:35 AM Melanie Plageman
> <melanieplageman(at)gmail(dot)com> wrote:
> > /src/backend/optimizer/prep/prepqual.c:582:33: warning: declaration of
> > ‘lc__state’ shadows a previous local [-Wshadow=compatible-local]
> > 582 | foreach(lc, entry->consts)
>
> Thank you for catching. I'm fixing this now.
I noticed the fix in question, and I wanted to say that this whole
issue could've been avoided if the new foreach_ptr macros were used
(and thus arguably would have been a better way to fix this). Then
there wouldn't have been any ListCell shadowing, because no ListCell
would have been declared at all.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2024-04-08 15:53:48 | Re: pgsql: Fix the intermittent buildfarm failures in 040_standby_failover_ |
| Previous Message | John Naylor | 2024-04-08 11:57:01 | pgsql: Teach radix tree to embed values at runtime |