Re: Flushing large data immediately in pqcomm

From: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Subject: Re: Flushing large data immediately in pqcomm
Date: 2024-04-08 12:27:44
Message-ID: CAGECzQRQ-i7kEiA7jtjC_VjDUOhykcJUMsy6bj8kwe5+k+9-yw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, 7 Apr 2024 at 11:34, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> That seems to require modifying the following function signatures:
> secure_write(), be_tls_write(), be_gssapi_write(). That's not an area
> I'm familiar with, however.

Attached is a new patchset where 0003 does exactly that. The only
place where we need to cast to non-const is for GSS, but that seems
fine (commit message has more details).

I also added patch 0002, which is a small addition to the function
comment of internal_flush_buffer that seemed useful to me to
differentiate it from internal_flush (feel free to ignore/rewrite).

Attachment Content-Type Size
v9-0001-Make-a-few-variables-size_t-in-pqcomm.c.patch application/octet-stream 1.3 KB
v9-0002-Expand-comment-of-internal_flush_buffer.patch application/octet-stream 991 bytes
v9-0003-Make-backend-libpq-write-functions-take-const-poi.patch application/octet-stream 4.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2024-04-08 12:29:59 Re: Improve eviction algorithm in ReorderBuffer
Previous Message John Naylor 2024-04-08 12:26:40 Re: [PoC] Improve dead tuple storage for lazy vacuum