Re: [PATCH] Align GSS and TLS error handling in PQconnectPoll()

From: Jelte Fennema <me(at)jeltef(dot)nl>
To: Jacob Champion <jchampion(at)timescale(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: [PATCH] Align GSS and TLS error handling in PQconnectPoll()
Date: 2023-02-16 11:31:46
Message-ID: CAGECzQR6p6HuMxPVNmovW0n5pAyBjDDz661hR1D9FwsKRuMH=A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Patch looks good to me. Definitely an improvement over the status quo.

Looking at the TLS error handling though I see these two lines:

&& conn->allow_ssl_try /* redundant? */
&& !conn->wait_ssl_try) /* redundant? */

Are they actually redundant like the comment suggests? If so, we
should probably remove them (in another patch). If not (or if we don't
know), should we have these same checks for GSS?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2023-02-16 11:34:23 Re: Missing default value of createrole_self_grant in document
Previous Message John Naylor 2023-02-16 11:28:23 Re: Todo: Teach planner to evaluate multiple windows in the optimal order