| From: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, jian he <jian(dot)universality(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Improve readability by using designated initializers when possible |
| Date: | 2024-03-05 14:03:54 |
| Message-ID: | CAGECzQQmd9UoA6UqGoa5iDO=419h2o26xZHnqXq9GWz2Vnnn9Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 5 Mar 2024 at 14:50, Japin Li <japinli(at)hotmail(dot)com> wrote:
> Attach a patch to rewrite dispatch_table array using C99-designated
> initializer syntax.
Looks good. Two small things:
+ [EEOP_LAST] = &&CASE_EEOP_LAST,
Is EEOP_LAST actually needed in this array? It seems unused afaict. If
indeed not needed, that would be good to remove in an additional
commit.
- *
- * The order of entries needs to be kept in sync with the dispatch_table[]
- * array in execExprInterp.c:ExecInterpExpr().
I think it would be good to at least keep the comment saying that this
array should be updated (only the order doesn't need to be strictly
kept in sync anymore).
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema-Nio | 2024-03-05 14:08:35 | Re: Reducing the log spam |
| Previous Message | Pavel Stehule | 2024-03-05 13:57:05 | Re: Reducing the log spam |