Re: Add --check option to pgindent

From: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Tristan Partin <tristan(at)neon(dot)tech>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Banck <mbanck(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add --check option to pgindent
Date: 2023-12-18 16:15:59
Message-ID: CAGECzQQcUA6AmoFhxMSewrMLgbmw1zRw3eKZzHNAKwjT+tGB_A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 18 Dec 2023 at 17:14, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> wrote:
> One thing I'm wondering: When both --check and --diff are passed,
> should pgindent still early exit with 2 on the first incorrectly
> formatted file? Or should it show diffs for all failing files? I'm
> leaning towards the latter making more sense.

To be clear, in the latter case it would still exit with 2 at the end
of the script, but only after showing diffs for all files.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema-Nio 2023-12-18 16:33:53 Re: psql JSON output format
Previous Message Jelte Fennema-Nio 2023-12-18 16:14:30 Re: Add --check option to pgindent