| From: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add a GUC check hook to ensure summarize_wal cannot be enabled when wal_level is minimal |
| Date: | 2024-07-10 14:29:14 |
| Message-ID: | CAGECzQQcLYiAdRj5xAm1G43MtpD_rm029ziqrbpqyDdxaCoEQA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 10 Jul 2024 at 16:18, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
> Yeah. I initially thought this patch might be okay, at least as a stopgap,
> but Jelte pointed out a case where it doesn't work, namely when you have
> something like the following in the config file:
>
> wal_level = 'minimal'
> summarize_wal = 'true'
> wal_level = 'logical'
I think that issue can be solved fairly easily by making the guc
check_hook always pass during postmaster startup (by e.g. checking
pmState), and relying on the previous startup check instead during
startup.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David E. Wheeler | 2024-07-10 14:33:05 | Re: jsonpath: Inconsistency of timestamp_tz() Output |
| Previous Message | Nathan Bossart | 2024-07-10 14:18:38 | Re: Add a GUC check hook to ensure summarize_wal cannot be enabled when wal_level is minimal |