Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

From: Anthony Emengo <aemengo(at)pivotal(dot)io>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel
Date: 2018-04-19 17:56:55
Message-ID: CAG8BBZOT8B6_e1igkos09dHPdG8Gk1ECoQjbV2WBxdBh50iqVw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hey Akshay

This patch passed our test pipelines.

Anthony and Victoria

On Thu, Apr 19, 2018 at 1:48 AM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:

> Hi Hackers
>
> I have implemented the SSH Tunnel support using https://pypi.org/
> project/sshtunnel/ python package. Added "SSH Tunnel" Tab in server
> dialog. This implementation supports user name /password and private/public
> key combination with Passphrase to crate SSH Tunnel. I have added
> regression test case to add server using SSH Tunnel options.
>
> The given python package(https://pypi.org/project/sshtunnel/) support
> Python version *2.7, 3.4+*.
> It uses Paramiko (Python implementation of SSHv2 protocol) which actually
> drops support for Python 2.6. So I have added *SUPPORT_SSH_TUNNEL* parameter
> in config.py which checks the python version and set the flag accordingly.
> In case of Python 2.6, 3.0, 3.1, 3.2 and 3.3 control on the "SSH Tunnel"
> tab of server dialog will be disabled.
>
> Please review it, and if looks good please commit the code.
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-04-20 08:12:06 pgAdmin 4 commit: Fix an error in the Japanese translation that caused
Previous Message Dave Page 2018-04-19 16:08:11 pgAdmin 4 commit: Fix python wheel dependencies.