Re: [PATCH] [RM# 3290] Close button missing for the message window from the backend server

From: Anthony Emengo <aemengo(at)pivotal(dot)io>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] [RM# 3290] Close button missing for the message window from the backend server
Date: 2018-04-23 14:34:18
Message-ID: CAG8BBZNqp3hRQX=jz7QFve0r_X8MMd=R7xB-=-PcuJ4ChALjJw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Just manually verified that this worked, and the patch successfully went
through our pipelines.

Thanks so much for fixing this issue!

- Joao and Anthony

On Mon, Apr 23, 2018 at 3:40 AM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com
> wrote:

> Hi Team,
>
> Please find the patch for fixing the RM #3290.
> The 'Close button' was missing in the message box, which shows the error
> in the backend server.
>
> This patch also fixes some of the missing keycode 'ESCAPE' on 'Cancel'
> buttons in different modules.
>
> Please review.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Anthony Emengo 2018-04-23 15:37:44 Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox
Previous Message Anthony Emengo 2018-04-23 14:02:44 Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel