Re: pgAdmin III commit: Modify the GNU build system so that it always rebui

Hi Timon,

If it shows modified, that means the one in the source control is older
once.
Hence - it is required to be checked-in the repository.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

On Tue, Jun 17, 2014 at 11:35 AM, Timon <timosha(at)gmail(dot)com> wrote:

> but after run "make" git shows pgadmin/ui/xrcDialogs.cpp as modified
> and we must run "git chekcout pgadmin/ui/xrcDialogs.cpp" before each
> rebase/commit/etc :(
>
> 2014-06-16 13:45 GMT+06:00 Dave Page <dpage(at)pgadmin(dot)org>:
> > No, because these changes only apply to *nix. We still need the file
> > in source control for Windows.
> >
> > On Mon, Jun 16, 2014 at 6:52 AM, Timon <timosha(at)gmail(dot)com> wrote:
> >> if xrcDialogs.cpp now rebuilds it should be remove from source and
> gitignored
> >>
> >>
> >> 2014-06-11 2:11 GMT+06:00 Dave Page <dpage(at)pgadmin(dot)org>:
> >>> Modify the GNU build system so that it always rebuilds xrcdialogs.cpp
> if
> >>> needed during a "make all". This also adds a "make xrc" target, and as
> >>> a side effect, allows use to call pgadmin/ui/embed-xrc from directories
> >>> other than pgadmin/ui.
> >>>
> >>> Branch
> >>> ------
> >>> master
> >>>
> >>> Details
> >>> -------
> >>>
> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=5cbe791efec2d00a27d0a7ec90f2f41f25368dd8
> >>>
> >>> Modified Files
> >>> --------------
> >>> Makefile.am | 5 ++++-
> >>> pgadmin/ui/embed-xrc | 12 +++++++++++-
> >>> 2 files changed, 15 insertions(+), 2 deletions(-)
> >>>
> >>>
> >>> --
> >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> >>> To make changes to your subscription:
> >>> http://www.postgresql.org/mailpref/pgadmin-hackers
> >>
> >>
> >>
> >> --
> >> All bugs reserved
> >
> >
> >
> > --
> > Dave Page
> > Blog: http://pgsnake.blogspot.com
> > Twitter: @pgsnake
> >
> > EnterpriseDB UK: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
>
>
>
> --
> All bugs reserved
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>