From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | [PATCH] Allow to skip the feature tests |
Date: | 2017-03-08 08:19:38 |
Message-ID: | CAG7mmozshi-Ocr2oCMuw3sBmSGQpTdW-fk2CBEjG1F5jh_OQjw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Dave/Team,
It is not possible to run the regression testsuite on a machine, where
chromium driver is not installed with the current implementation, because -
we initialize the selenium webdriver on startup without checking whether it
is needed, or not.
I have attached the patch to take care of the issue.
It skips the webdriver initialization, and other related parameters, if
'feature_tests' is explicitly added in the exclude package list.
This will allow us to run the regression-suite using the following command
without the need of installing the chromedriver on the host machine.
i.e.
*python runtests.py --exclude feature_tests*
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>
Attachment | Content-Type | Size |
---|---|---|
skip_feature_test.patch | application/octet-stream | 2.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-03-08 09:21:31 | pgAdmin 4 commit: Don't try to start chromedriver and friends if the fe |
Previous Message | Dave Page | 2017-03-07 21:26:44 | Re: [Design Update][History] |