Re: pgAdmin III commit: Resolved an issue related enable/disable menu items

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: "J(dot)F(dot) Oster" <jinfroster(at)mail(dot)ru>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAdmin III commit: Resolved an issue related enable/disable menu items
Date: 2015-09-23 05:06:46
Message-ID: CAG7mmozYwB_7PxKQKpB2knNRONwyh+2zScN83MsWX9qNBnyZgg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Wed, Sep 23, 2015 at 10:27 AM, Ashesh Vashi <
ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:

> On Wed, Sep 23, 2015 at 10:23 AM, J.F. Oster <jinfroster(at)mail(dot)ru> wrote:
>
>> Hi Ashesh,
>>
>> Favourite's issue is resolved, but looks like Edit - Cut/Copy/Paste
>> items are disabled all the time (seen on Ubuntu, Kubuntu).
>>
> I've tested the patch couple of times on Ubuntu, and OSX both before
> committing the changes.
>
> Do you have time to look into it?
>
Got the reason.
Thanks for the report.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
>>
>> Tuesday, September 22, 2015, 10:56:32 AM, you wrote:
>>
>> AV> Resolved an issue related enable/disable menu items in Query Editor
>> AV> specifically for Unity Desktop Environment.
>>
>> AV> wxWidgets was not able to identify the current focused control in some
>> AV> cases, during certain event generation. And, that was resulting into
>> AV> disabling the wrong menu items.
>> AV> i.e.
>> AV> Copy, Paste, Undo, Redo, Cut, Paste, Add/Manage favourite menu(s)
>>
>> AV> In order to resolve the issue, we will not consider the events
>> AV> generated, but - no control gets focused, while enabling/disabling the
>> AV> menus.
>>
>> AV> Branch
>> AV> ------
>> AV> master
>>
>> AV> Details
>> AV> -------
>> AV>
>> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=cd9f615564334ed91d4760c971beae249cf9bd83
>>
>> AV> Modified Files
>> AV> --------------
>> AV> CHANGELOG | 3 +++
>> AV> pgadmin/frm/frmQuery.cpp | 59
>> AV> +++++++++++++++++++++++++++-------------------
>> AV> 2 files changed, 38 insertions(+), 24 deletions(-)
>>
>>
>>
>>
>>
>> --
>> Best regards,
>> J.F.
>>
>>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2015-09-23 05:11:05 pgAdmin III commit: Moved some of the code in wrong place related to en
Previous Message Ashesh Vashi 2015-09-23 04:57:18 Re: pgAdmin III commit: Resolved an issue related enable/disable menu items