From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Vladimir Kokovic <vladimir(dot)kokovic(at)gmail(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: frmQuery (multiple result sets support) - patch no.2 |
Date: | 2012-11-19 04:12:24 |
Message-ID: | CAG7mmozUbxSDDh4R4cu2--sQRojvAkiGhkdf6nvBfu3rP6uPGw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Sun, Oct 21, 2012 at 1:45 PM, Vladimir Kokovic <
vladimir(dot)kokovic(at)gmail(dot)com> wrote:
> Hi,
>
> My try to add multiple result sets support !
>
Hi Vladimir Kokovic,
I am not able to apply the patch cleanly on master branch.
*patch -p1 < ~/Downloads/pgadmin3-2.diff*
*patching file pgadmin/frm/frmQuery.cpp*
*Hunk #6 succeeded at 2193 (offset 6 lines).*
*Hunk #7 succeeded at 2288 (offset 6 lines).*
*Hunk #8 succeeded at 2574 (offset 6 lines).*
*Hunk #9 succeeded at 2631 (offset 6 lines).*
*Hunk #10 succeeded at 2649 (offset 6 lines).*
*Hunk #11 succeeded at 2680 (offset 6 lines).*
*Hunk #12 succeeded at 2785 (offset 6 lines).*
*Hunk #13 succeeded at 2840 (offset 6 lines).*
*Hunk #14 succeeded at 2882 (offset 6 lines).*
*Hunk #15 succeeded at 2955 (offset 6 lines).*
*Hunk #16 succeeded at 3034 (offset 6 lines).*
*patching file pgadmin/include/frm/frmQuery.h*
*patch unexpectedly ends in middle of line*
*Hunk #3 succeeded at 310 with fuzz 1.*
Can you please take a look at it?
Before - you send the new updated patch, please make sure:
- Use the camel-case instead of underscore in class-name and objects.
- Please do not add new macros unless necessary, and if you find it
necessary
give proper comments for it.
- Write comments for your actions.
- Please test the patch at your end before sending it to the community.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com/>
*http://www.linkedin.com/in/asheshvashi*
>
> Best regards
> Vladimir Kokovic
> Belgrade, Serbia, 21.October 2012
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Ashesh Vashi | 2012-11-19 04:50:34 | Re: copy/paste table(s) - patch no.3 |
Previous Message | Magnus Hagander | 2012-11-15 14:58:41 | pgAdmin III commit: Fix bad wording in create role dialog |