Re: server and database node type check in is_connected check [pgadmin4]

On Tue, May 24, 2016 at 12:26 PM, Harshal Dhumal <
harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:

> Hi Ashesh,
>
> For change server password we have added check is_connected() in
> server.js. Also same function is also available in database.js. So it was
> causing change server password menu to enable on database node as well if
> database is connected.
>
> This issue will appear for any other menu if that menu has check on
> is_connected function.
>
In that case - we're fixing it at wrong end.
We need make the menu educate about the node type it supports, and
enable/disable it accordingly.

Please modify the 'update' function 'pgAdmin.Browser.MenuItem' class in
'web/pgadmin/browser/static/js/menu.js' accordingly.

--
Thanks & Regards,

Ashesh Vashi

>
>
>
>
> --
> *Harshal Dhumal*
> *Software Engineer *
>
>
>
> EenterpriseDB <http://www.enterprisedb.com>
>
> On Tue, May 24, 2016 at 12:13 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>>
>> On Tue, May 24, 2016 at 12:06 PM, Harshal Dhumal <
>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>>
>>> PFA patch for server and database node:
>>>
>>> Issue fixed: Added node type check in is_connected check.
>>>
>>
>> Can you please describe the situation, when these functions are being
>> executed outside the respective node instance?
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com/>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>>> --
>>> *Harshal Dhumal*
>>> *Software Engineer *
>>>
>>>
>>>
>>> EenterpriseDB <http://www.enterprisedb.com>
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>